Conversation
bboreham
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno and
mdisibio
as code owners
mapno
approved these changes
Jul 14, 2021
annanay25
approved these changes
Jul 14, 2021
Create a new span for each flush, log the trace ID, and any error that comes back. Passing a context in to `handleFlush()` seems more natural than having it assume it is only called in background context.
Contributor
Author
|
Re-pushed with simpler span creation and changelog. I realise this could be a common util with Cortex; I specifically dislike the current implementation in Cortex so will need to fix that before making them common. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Create a new span for each flush, log the trace ID, and any error that comes back.
Passing a context in to
handleFlush()seems more natural than having it assume it is only called in background context.Checklist
CHANGELOG.mdupdated