Skip to content

Use OpenTelemetry tracer, bridge OpenTracing and OpenCensus#842

Merged
mdisibio merged 25 commits intografana:mainfrom
yvrhdn:otel-bridge
Aug 6, 2021
Merged

Use OpenTelemetry tracer, bridge OpenTracing and OpenCensus#842
mdisibio merged 25 commits intografana:mainfrom
yvrhdn:otel-bridge

Conversation

@yvrhdn
Copy link
Copy Markdown
Contributor

@yvrhdn yvrhdn commented Jul 28, 2021

What this PR does:
Adds a new feature flag use_otel_tracer which replaces the OpenTracing tracer with the OpenTelemetry tracer. The OTel tracer will install two bridges (OpenTracing and OpenCensus) so all existing spans will be collected and sent.

Why?

  • This will allows us to gather OpenCensus spans, these are for instance emitted by the GCS SDK.
  • OpenTracing has merged into OpenTelemetry

The feature flag defaults to false, i.e. keep using the OpenTracing tracer as before. There are a couple of issue we still need to iron out and not all features match (i.e. remote sampling is missing from the Jaeger exporter).

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@yvrhdn
Copy link
Copy Markdown
Contributor Author

yvrhdn commented Jul 28, 2021

Issues:

@yvrhdn yvrhdn changed the title Experimental: Use OpenTelemetry tracer, bridge OpenTracing and OpenCensus Use OpenTelemetry tracer, bridge OpenTracing and OpenCensus Jul 29, 2021
@yvrhdn
Copy link
Copy Markdown
Contributor Author

yvrhdn commented Jul 29, 2021

Example trace with spans from the GCS SDK
Screenshot 2021-07-29 at 16 08 36

@yvrhdn
Copy link
Copy Markdown
Contributor Author

yvrhdn commented Jul 30, 2021

Process tags have changed slightly:

OpenTracing

Screenshot 2021-07-30 at 12 45 10

OpenTelemetry

Screenshot 2021-07-30 at 12 46 14

@yvrhdn yvrhdn marked this pull request as ready for review July 30, 2021 11:48
Comment thread cmd/tempo/main.go
Comment thread cmd/tempo/main.go Outdated
Comment thread modules/frontend/frontend.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants