Enhancement: Make s3 backend readError logic more robust#905
Merged
mapno merged 9 commits intografana:mainfrom Aug 27, 2021
wei840222:main
Merged
Enhancement: Make s3 backend readError logic more robust#905mapno merged 9 commits intografana:mainfrom wei840222:main
mapno merged 9 commits intografana:mainfrom
wei840222:main
Conversation
mapno
reviewed
Aug 24, 2021
Contributor
|
Sorry, I re-read your description and saw the explanation |
Contributor
Author
|
I think it is make sense to just check the code. |
Contributor
Author
|
@mapno I've changed. |
joe-elliott
reviewed
Aug 24, 2021
Contributor
Author
|
It seems need approved for run CI. |
Collaborator
|
Thanks for the contribution, wei. We will wait til we cut 1.1 to merge. |
Contributor
Author
|
Got it, thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for some s3 compatible storage backend, it may has differnt error messsage when object not exist.
I think using minio.error code for judge the object is not exist is more robust.