Make overrides configmap block name consistent#906
Merged
Conversation
annanay25
reviewed
Aug 24, 2021
Contributor
annanay25
left a comment
There was a problem hiding this comment.
Is the name going to be used in a script/automation setting? Tempo has a consistent naming convention in the jsonnets at the moment, all configmaps have the _configmap suffix. Would be nice if we could retain that, but its ok to make the change if needed
Contributor
Author
|
@annanay25 Yea unfortunately I think we have to keep it But I totally understand and agree with your naming consistency concern within tempo. I can happily change it to |
annanay25
approved these changes
Aug 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
It edit tempo microservices jsonnet and makes the
overrides_configblock name consistent with Loki and CortexWhich issue(s) this PR fixes:
Fixes #NA
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]