Add runtime config handler#936
Merged
mapno merged 6 commits intografana:mainfrom Sep 13, 2021
Merged
Conversation
annanay25
reviewed
Sep 7, 2021
mapno
requested review from
dgzlopes,
joe-elliott,
mdisibio and
yvrhdn
as code owners
mapno
force-pushed
the
overrides-handler
branch
2 times, most recently
from
aff22f8 to
3c85788
Compare
mapno
force-pushed
the
overrides-handler
branch
from
adbb870 to
50e2442
Compare
annanay25
approved these changes
Sep 10, 2021
| // we set defaultLimits for every tenant that exists in runtime config. | ||
| defaultCfg := perTenantOverrides{TenantLimits: map[string]*Limits{}} | ||
| defaultCfg.TenantLimits = map[string]*Limits{} | ||
| for k, v := range tenantOverrides.TenantLimits { |
Contributor
There was a problem hiding this comment.
I think this will result in null pointer dereference if o.tenantOverrides == nil
Contributor
Author
There was a problem hiding this comment.
I think it's fine since we're instantiating a zero value in line 153 and only assign a value if o.tenantOverrides() != nil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a runtime config handler at
/runtime_configWhich issue(s) this PR fixes:
Fixes #893
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]