Skip to content

Make tempo use runtimeconfig from dskit instead of cortex#945

Merged
annanay25 merged 4 commits intomainfrom
tempo-runtimeconfig-from-dskit
Sep 10, 2021
Merged

Make tempo use runtimeconfig from dskit instead of cortex#945
annanay25 merged 4 commits intomainfrom
tempo-runtimeconfig-from-dskit

Conversation

@kavirajk
Copy link
Copy Markdown
Contributor

@kavirajk kavirajk commented Sep 10, 2021

What this PR does:
Make tempo use runtimeconfig from dskit instead of cortex (similar to Loki)

Which issue(s) this PR fixes:
Fixes # NA

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Comment thread modules/overrides/overrides.go Outdated
Copy link
Copy Markdown
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes Kavi.

Pinging @mapno because he is currently making changes to this module as well.

Comment thread modules/overrides/overrides.go Outdated
Copy link
Copy Markdown
Contributor

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread CHANGELOG.md Outdated
Comment thread modules/overrides/overrides.go
@annanay25 annanay25 merged commit 8b389d4 into main Sep 10, 2021
@annanay25 annanay25 deleted the tempo-runtimeconfig-from-dskit branch September 10, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants