Skip to content

Zstd decoder#948

Merged
joe-elliott merged 16 commits intografana:mainfrom
joe-elliott:zstd-decoder
Sep 15, 2021
Merged

Zstd decoder#948
joe-elliott merged 16 commits intografana:mainfrom
joe-elliott:zstd-decoder

Conversation

@joe-elliott
Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott commented Sep 13, 2021

What this PR does:

  • Use the zstd decoder instead of the streaming io.Reader for reads. Seeing a 10-20% increase in throughput when iterating a block and 10-20% decrease in compactor CPU with this change.
  • Update klauspost/compress dependency to latest

I also attempted the same change for the encoder/writing, but saw a performance regression so I left it out.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Joe Elliott <number101010@gmail.com>

sadness

Signed-off-by: Joe Elliott <number101010@gmail.com>

removed encoding

Signed-off-by: Joe Elliott <number101010@gmail.com>

duh

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
This reverts commit 04bae4a.
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
This reverts commit 4b1e3cd.
This reverts commit b081970.
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Comment thread tempodb/encoding/v2/data_reader.go
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Copy link
Copy Markdown
Contributor

@mdisibio mdisibio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg (enough) tm !

@joe-elliott joe-elliott merged commit e976a08 into grafana:main Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants