Add search block headers for wal blocks#963
Merged
annanay25 merged 2 commits intografana:mainfrom Sep 21, 2021
Merged
Conversation
Signed-off-by: Martin Disibio <mdisibio@gmail.com>
mdisibio
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno and
yvrhdn
as code owners
annanay25
approved these changes
Sep 17, 2021
Contributor
annanay25
left a comment
annanay25
left a comment
There was a problem hiding this comment.
Looking really good. Changelog entry and we should merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Maintains a search blocker header for wal blocks like #943 did for completed blocks. This helps eliminate blocks from the search faster for non-existent or sparse values.
The wal requires a mutable header, so some refactoring was done to better fit the search pipeline and the various trace/page/block structs together, i.e. the pipeline can now match directly against a SearchBlockHeaderMutable.
Which issue(s) this PR fixes:
Fixes some of #932
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]