Set span.kind to client in query-frontend#975
Merged
mapno merged 4 commits intografana:mainfrom Sep 29, 2021
Merged
Conversation
mapno
requested review from
annanay25,
dgzlopes,
joe-elliott,
mdisibio and
yvrhdn
as code owners
annanay25
approved these changes
Sep 22, 2021
Contributor
annanay25
left a comment
annanay25
left a comment
There was a problem hiding this comment.
Approving to unblock, left a minor comment
joe-elliott
approved these changes
Sep 23, 2021
mapno
force-pushed
the
client-tag-retry-middleware
branch
from
ac4e2a1 to
124f71e
Compare
annanay25
reviewed
Sep 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
It sets
span.kindtoclientin query-frontend's retry middleware spans. This allows for query-frontend client spans to be paired with querier server spans.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]