Nil check overrides module in /status endpoint#994
Merged
mapno merged 1 commit intografana:mainfrom Oct 4, 2021
Merged
Conversation
mapno
requested review from
annanay25,
dgzlopes,
joe-elliott,
mdisibio and
yvrhdn
as code owners
mapno
force-pushed
the
overrides-module-dep-querier-fronted
branch
from
810eb23 to
de6d0a0
Compare
joe-elliott
requested changes
Sep 29, 2021
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
We should just check for nil and print a message like "overrides not loaded". There's no reason to scan for overrides in these services.
Querier and query-frontend do not run the overrides module. The status handler now checks in that module is being run and skips it in case it isn't.
mapno
force-pushed
the
overrides-module-dep-querier-fronted
branch
from
de6d0a0 to
10fac86
Compare
mapno
changed the title
overrides module as dependency of querier and query-frontend
joe-elliott
approved these changes
Oct 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Nil check overrides module in /status endpoint
Querier and query-frontend do not run the overrides module. The status handler now checks in that module is being run and skips it in case it isn't.
It also modifies the distributed docker-compose to run minio with
miniocommand, instead of executing the binary.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]