Updated to use Go 1.7 request based context#17
Closed
nicholasjackson wants to merge 1 commit into
Closed
Conversation
Restored interface for backward compatibility Tidy, update travis config.yml Added test for Go 1.7 context
nicholasjackson
force-pushed
the
master
branch
from
e6e98d0 to
49e51bc
Compare
hallettj
pushed a commit
to InVisionApp/handler
that referenced
this pull request
Dec 29, 2016
merges pull request: graphql-go#17
|
Now that this change was applied in the https://github.com/graphql-go/graphql library in this PR: graphql-go/graphql#214 , can it also be merged here? Thanks! |
Member
|
closing this one in favor of #23 — thanks a lot @nicholasjackson! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since context has been merged as stable in Go 1.7 and is now part of the request object (https://godoc.org/net/http#Request)[https://godoc.org/net/http#Request]. This pull request modifies the behavior of the ServeHTTP method to use the request.Context() on go 1.7. Backward compatibility is preserved for version less than 1.7 by using build constraints.
I have also refactored the tests a little removing the TODO and adding a specific test for Go 1.7 context in the request.