Conversation
943bee0 to
3a27d35
Compare
3a27d35 to
8ad6960
Compare
🦋 Changeset detectedLatest commit: 9fff3b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8ad6960 to
76ee61d
Compare
76ee61d to
13c0a7a
Compare
Contributor
✅ Benchmark Results |
Contributor
|
The latest changes of this PR are available as canary in npm (based on the declared |
n1ru4l
commented
Jul 12, 2022
| let page: puppeteer.Page; | ||
|
|
||
| describe('SvelteKit integration', () => { | ||
| describe.skip('SvelteKit integration', () => { |
Collaborator
Author
There was a problem hiding this comment.
Skipping because it is also broken on master. See #1378
Contributor
There was a problem hiding this comment.
@dotansimha @n1ru4l the SvelteKit integration has been broken in the following PR that introduced breaking changes in yoga/common: #1364
dotansimha
reviewed
Jul 12, 2022
dotansimha
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypedEventTargettype into a standalon package@graphql-yoga/typed-event-target.@graphql-yoga/redis-event-targetpackage which has a EventTarget implementation based on redis pub/sub usingioredisFuture thoughts:
dataattribute, and now I figured out that there is alsoCustomEvent, but it is still not available in the latest Node.js. Changing the API to useCustomEventwould be a breaking change, thus for now I kept re-using theEvent. In the next major release, we can consider usingCustomEventinstead.Node.js Progress for supporting
CustomEvent:CustomEventnodejs/node#43514Closes #1297