Validate shape of cacheMap on initialization#86
Merged
Conversation
Author
|
Hmm, I'm having some trouble figuring out how code coverage dropped. It looks like the new test should exercise the added functionality, but maybe I'm overlooking something simple. EDIT: Turns out it was untested lines in the new test. |
sidsethupathi
force-pushed
the
cache-map-shape
branch
from
bdf8e0b to
e323ec6
Compare
* Functions should avoid being defined within another function body if possible * Naming consistency * Flow typing * Arrow functions with a single return statement should not use block format * Check typeof 'function' instead of non-falsey * filter(Boolean) to remove falsey values
sidsethupathi
commented
Oct 19, 2017
| } | ||
|
|
||
| function getValidCacheMap<K, V>( | ||
| options: Options<K, V> |
Author
There was a problem hiding this comment.
I'm pretty new to flow, but shouldn't this be options??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #82
Checks to see if custom cache map has the required methods on initialization. The documentation just says it needs to be an object with a similar API to Map but the DataLoader only uses those 4 methods, so I figured it was okay to selectively check for those.