Skip to content

Allow passing arbitrary flags to Qhull #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 30, 2020

Conversation

eschnett
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   92.50%   92.50%           
=======================================
  Files           3        3           
  Lines          40       40           
=======================================
  Hits           37       37           
  Misses          3        3           
Impacted Files Coverage Δ
src/bindings.jl 100.00% <ø> (ø)
src/MiniQhull.jl 100.00% <100.00%> (ø)
src/load.jl 76.92% <0.00%> (-1.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a212b...e2ff4e6. Read the comment docs.

Copy link
Member

@fverdugo fverdugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eschnett thanks for your PR.

Can you add some test of the new API in the test folder? Please consider the case in which flags is a String object and also some case in which it is other type of AbstractString with different data layout. Just to make sure that we don't have problems when passing some exotic string type.

@eschnett
Copy link
Contributor Author

I added tests, including one for a GenericString instead of a String:

help?> Test.GenericString
  The GenericString can be used to test generic string APIs that program to
  the AbstractString interface, in order to ensure that functions can work
  with string types besides the standard String type.

@fverdugo fverdugo merged commit a5271ea into gridap:master Oct 30, 2020
@fverdugo
Copy link
Member

@eschnett thanks for your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants