This repository was archived by the owner on Apr 28, 2025. It is now read-only.
catch backend errors in 'get' or 'getOrElse' and follow 'orElse' when they occur #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| obj = | ||
| errorGenerator: (callback) -> callback(new Error('backend troubles')) | ||
|
|
||
| bond(cache, 'getWrapped').return(Q.npost(obj, "errorGenerator")) |
There was a problem hiding this comment.
This could be written as: bond(cache, 'getWrapped').return Q.reject new Error('backend troubles'). This makes the function return a rejected promise ("throw an error").
There was a problem hiding this comment.
updated (forgot which email these updates go to, just read it)
|
Small stylistic note, otherwise looks good! |
|
LGTM! Will publish as bug fix. |
jkrems
added a commit
that referenced
this pull request
Apr 17, 2014
catch backend errors in 'get' or 'getOrElse' and follow 'orElse' when they occur
|
v2.0.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeouts and other errors in
getWrappedcurrently cause errors/rejections that are passed all the way through to the callback ingetOrElse- The expected behavior is more likely to be that the passed-in value or value function is used in the case of any problems retrieving the given key.