protoc-gen-go-grpc: add period to end of generated comment#7392
protoc-gen-go-grpc: add period to end of generated comment#7392dfawley merged 9 commits intogrpc:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7392 +/- ##
==========================================
+ Coverage 81.50% 81.55% +0.05%
==========================================
Files 348 348
Lines 26752 26752
==========================================
+ Hits 21804 21818 +14
+ Misses 3766 3757 -9
+ Partials 1182 1177 -5 |
|
@purnesh42H previous PR #7362 do consider this one |
|
Thanks @infovivek2020. LGTM. Please take a look at some of the other submitted PRs and add RELEASE NOTES section in your PR description as part of Mergeable check |
|
@infovivek2020 can you comment on the issue #7350 that you have raised a PR for this so that I can assign it to you |
|
@infovivek2020 just a reminder to add RELEASE NOTES in the PR description so that we can go ahead and merge |
|
@infovivek2020 don't edit |
…face comment is added to the generated protoc gen
|
@infovivek2020 : Could you please sign the CLA. |
|
@purnesh42H right now i am facing "HEAD is now at 0dfcf4e Merge c26c5bd into daab563 |
|
@arvindbr8 is the vet issue fixed? Do we have to regenerate the protos again? |
This PR affects codegen, so it should regenerate everything regardless. |
Not very important, but relevant for this PR. This #7351 introduce support for editions. However our regenerate scripts is broken complaining something like this: I'm investigating this. Let me see if I get some time to fix this today. |
yeah I mean the protos are regenerated but do we have to regenerate again after Arvind's fix? |
|
@infovivek2020 can you pull and rebase your branch on latest upstream and then run |
|
@infovivek2020 looks like you got unwanted files in your push. Can you try following
|
987e637 to
d9a3efc
Compare
|
@dfawley this looks good to be merged |
Addresses: #7350
RELEASE NOTES: N/A