cleanup: replace dial with newclient #7975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
reviewed
Dec 31, 2024
arjan-bal
reviewed
Dec 31, 2024
arjan-bal
reviewed
Dec 31, 2024
arjan-bal
reviewed
Dec 31, 2024
…tification channel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7975 +/- ##
========================================
Coverage 82.28% 82.28%
========================================
Files 381 387 +6
Lines 38539 38967 +428
========================================
+ Hits 31712 32065 +353
- Misses 5535 5586 +51
- Partials 1292 1316 +24 |
arjan-bal
reviewed
Dec 31, 2024
arjan-bal
added
Type: Testing
Type: Internal Cleanup
arjan-bal
reviewed
Jan 2, 2025
arjan-bal
reviewed
Jan 20, 2025
arjan-bal
reviewed
Jan 21, 2025
|
All the review comments are addressed. |
dfawley
reviewed
Feb 3, 2025
dfawley
approved these changes
Feb 14, 2025
arjan-bal
reviewed
Feb 17, 2025
Comment on lines
40
to
42
| const ( | ||
| defaultTestTimeout = 5 * time.Second | ||
| ) |
There was a problem hiding this comment.
Since there's only a single const, this can be made a single line.
arjan-bal
approved these changes
Feb 17, 2025
janardhanvissa
added a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address: #7049
RELEASE NOTES: None