xds: Make locality ID string representation consistent with A78 #8256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
added
Type: Bug
Area: xDS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8256 +/- ##
==========================================
+ Coverage 82.01% 82.23% +0.22%
==========================================
Files 412 412
Lines 40488 40477 -11
==========================================
+ Hits 33206 33287 +81
+ Misses 5900 5834 -66
+ Partials 1382 1356 -26
🚀 New features to boost your workflow:
|
dfawley
reviewed
Apr 16, 2025
| TotalDrops: dropCount, | ||
| Drops: map[string]uint64{dropReason: dropCount}, | ||
| LocalityStats: map[string]load.LocalityData{ | ||
| assertString(xdsinternal.LocalityID{}.ToString): {RequestStats: load.RequestData{ |
There was a problem hiding this comment.
Please delete assertString since it is unused now.
dfawley
approved these changes
Apr 16, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal issue: b/397462082
The format of the locality ID used for reporting metrics is specified here: https://github.com/grpc/proposal/blob/master/A78-grpc-metrics-wrr-pf-xds.md#optional-xds-locality-label
gRPC Go uses JSON which is inconsistent with other gRPC implementations. This PR fixes this.
RELEASE NOTES: