xds: allow empty nodeID in bootstrap configuration #8476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes grpc#8473 Matches the implementation of [grpc C++](https://github.com/grpc/grpc/blob/2ca9ac63ced7b77cf0eb885276fbedec1ab0bd10/src/core/xds/grpc/xds_bootstrap_grpc.cc#L67) and Envoy that makes the node ID optional. Signed-off-by: sotiris <[email protected]>
The committers listed above are authorized under a signed CLA. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8476 +/- ##
==========================================
- Coverage 82.47% 82.37% -0.11%
==========================================
Files 413 413
Lines 40513 40511 -2
==========================================
- Hits 33415 33369 -46
- Misses 5743 5774 +31
- Partials 1355 1368 +13
🚀 New features to boost your workflow:
|
|
cc @easwars Also this is tested via unit tests but let me know if you want me to add integration tests somewhere |
eshitachandwani
added
Type: Bug
Area: xDS
|
LGTM , adding @easwars to take a look. |
eshitachandwani
approved these changes
Jul 29, 2025
easwars
approved these changes
Jul 29, 2025
|
Thank you for your contribution @davinci26 |
easwars
changed the title
dimpavloff
pushed a commit
to dimpavloff/grpc-go
that referenced
this pull request
Aug 22, 2025
eshitachandwani
pushed a commit
to eshitachandwani/grpc-go
that referenced
this pull request
Aug 26, 2025
eshitachandwani
added a commit
that referenced
this pull request
Aug 26, 2025
Original PRs : #8476 , #8483 Related issues : #8473 , #8474 RELEASE NOTES: - xds: Revert to allowing empty node ID in xDS bootstrap configuration - lrsclient: - Fix a race condition where the LRSClient was not initialized at creation time but it was being initialized at the time of calling the ReportLoad function. - Creating an LRSClient no longer requires a node ID. --------- Co-authored-by: Sotiris Nanopoulos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8473
Matches the implementation of grpc C++ and Envoy that makes the node ID optional.
RELEASE NOTES: