stats: change non-standard units to annotations #8481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC Go has been specifying units as non-standard values such as
call
andendpoint
instead of using annotations like{call}
. Based on the metric naming conventions anything enclosed in curly braces is an annotation and in the absence of a prefix, the unit is1
. The gRPC docs also mention that non-standard units need to be enclosed in curly braces: https://grpc.io/docs/guides/opentelemetry-metrics/#per-call-metrics.This bug was caught due to a regression in the otel prometheus exporter: #8479
RELEASE NOTES:
call
andendpoint
in curly braces to comply with UCUM and gRPC OpenTelemetry guidelines.