pickfirst: Remove old pickfirst#8672
Merged
arjan-bal merged 9 commits intogrpc:masterfrom Oct 28, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8672 +/- ##
==========================================
+ Coverage 83.03% 83.15% +0.11%
==========================================
Files 417 417
Lines 32310 32182 -128
==========================================
- Hits 26829 26761 -68
+ Misses 4087 4038 -49
+ Partials 1394 1383 -11
🚀 New features to boost your workflow:
|
dfawley
approved these changes
Oct 27, 2025
| @@ -26,889 +26,18 @@ | |||
| package pickfirstleaf | |||
Contributor
Author
There was a problem hiding this comment.
Done. Since this PR is removing a test workflow, it will higher extra privileges to merge.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8561
Addresses: #6472
The new pickfirst has been the default since gRPC Go v1.71.0 and all reported bugs have been fixed. This PR removes the old pickfirst policy completely.
The exported symbols in the
pickfirstleafpackage are retained with a deprecation notice for removal after one release.RELEASE NOTES:
pick_firstLB policy. The newpick_firsthas been the default since v 1.71.0.