Parse target URIs as RFC 3986 (if flagged) #12573
Open
+550
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings grpc-java in compliance with the grpc name syntax standard. Please review each commit individually -- I do not plan to squash.
This is technically a breaking change because there's a set of target strings that previously parsed fine under java.net.URI but will now throw. There are 2 known types:
Even though both of these are unlikely, we guard the behavior change behind the
GRPC_ENABLE_RFC3986_URISflag (off by default). Technically NameResolverProvider is a public API so there could be resolvers out in the world that we haven't considered.