Break timer retain cycle #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The timers used by the client/server connection management hanlders indirectly hold references to the underlying handler. The hanlder holds a reference to the timer. This cycle isn't broken so a handler is leaked for each connection. Modifications: - Nil out the timers to break the retain cycle when the channel becomes inactive Result: - Fewer leaks - Resolves grpc#84
Closed
|
Thanks for the quick resolution with this PR! |
gjcairo
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The timers used by the client/server connection management hanlders indirectly hold references to the underlying handler. The hanlder holds a reference to the timer. This cycle isn't broken so a handler is leaked for each connection.
Modifications:
Result: