Fix bad transition when server sends invalid headers in stream state machine #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Apr 11, 2025
| buffer.writeInteger(UInt8(0)) // not compressed | ||
| buffer.writeInteger(UInt32(42)) // message length | ||
| buffer.writeRepeatingByte(0, count: 42) // message | ||
| let serverDataPayload = HTTP2Frame.FramePayload.Data(data: .byteBuffer(buffer), endStream: true) |
There was a problem hiding this comment.
What about the server sending trailers with end stream set? We should cover that case as well.
gjcairo
force-pushed
the
fix-bad-transition
branch
from
9a6a17b to
b0b2097
Compare
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
May 14, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `gRPC Swift NIO Transport` library to 1.1.0. ### Why are the changes needed? To bring the latest big fixes with the official Swift 6.1 tested version. - https://github.com/grpc/grpc-swift-nio-transport/releases/tag/1.1.0 - grpc/grpc-swift-nio-transport#88 - grpc/grpc-swift-nio-transport#94 - grpc/grpc-swift-nio-transport#89 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #147 from dongjoon-hyun/SPARK-52138. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While triaging #83 we discovered an issue with the stream state machine, where we would not transition the server to
closedwhen receiving invalid headers. This is not correct, because at this point the server is in an unrecoverable state from the client's perspective, and we should ignore any subsequent messages.This PR fixes this transition, which was causing an "invalid state" error (or runtime crash in debug mode). It now drops any further messages from the server on the floor, instead of throwing/sending another error message back to the client.
I've also fixed a problem with receiving headers with a 1xx status code: they should be ignored, but we were transitioning to closed states instead.