Don't fail when there are no spec files to be run #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
guard-rspecthrows:task_has_failedwhen there are no spec files to be run.This change makes
guard-rspecabort without failing in that case.Example
Here's an
Guardfilewith a group withhalt_on_failoption:When I modified a library file that has no corresponding spec file (i.e.
lib/foo.rbexists butspec/foo_spec.rbdoesn't exist),guard-rspecfails andguard-rubocopwon't run.Actually I'm still not sure whether this is a specification or a bug, though I feel this is strange and inconvenient.
What do you think?
Environment
guard2.2.5guard-rspec4.2.0Gemfile: