Skip to content

Revert "Drop sub-component targets (#8966)" #9690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Feb 2, 2024

This reverts commit 3f4c81f.

Please read Github PR Conventions and then fill in one of these two templates.


Template Β: This PR does not modify cabal behaviour (documentation, tests, refactoring, etc.)

Include the following checklist in your PR:

Closes #9688

@fendor
Copy link
Collaborator Author

fendor commented Feb 2, 2024

This does not need to be merged as is but serves as somewhat of a reminder :)

@andreabedini
Copy link
Collaborator

It's clear the ecosystem is put togheter with sticky tape

If this is the only option, I reckon it's a fair call to revert.

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this reverts #8966.

I agree it's unfortunate we have to revert this. Let's at least try to improve the API, docs, tests.

@mpickering mpickering added the merge me Tell Mergify Bot to merge label Feb 6, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Feb 8, 2024
@Mikolaj
Copy link
Member

Mikolaj commented Feb 8, 2024

A random CI infra failure: "Mikolaj token is invalid, make sure Mikolaj can still log in on the Mergify dashboard."

I will keep insisting.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 8, 2024

@mergify refresh

Copy link
Contributor

mergify bot commented Feb 8, 2024

refresh

✅ Pull request refreshed

@Mikolaj
Copy link
Member

Mikolaj commented Feb 8, 2024

@mergify unqueue

Copy link
Contributor

mergify bot commented Feb 8, 2024

unqueue

☑️ The pull request is not queued

@Mikolaj
Copy link
Member

Mikolaj commented Feb 8, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Feb 8, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 8, 2024

@mergify rebase

Copy link
Contributor

mergify bot commented Feb 8, 2024

rebase

❌ Base branch update has failed

Mikolaj token is invalid, make sure Mikolaj can still log in on the Mergify dashboard.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 8, 2024

I'm able to rebase just fine in #9698, so may this be something wrong with the PR? I can see "Maintainers are allowed to edit this pull request" and I don't know what else can be broken. @ulysses4ever, any ideas?

@ulysses4ever
Copy link
Collaborator

@mergify rebase

Copy link
Contributor

mergify bot commented Feb 8, 2024

rebase

❌ Base branch update has failed

ulysses4ever token is invalid, make sure ulysses4ever can still log in on the Mergify dashboard.

@ulysses4ever
Copy link
Collaborator

@ulysses4ever, any ideas?

not really. Let's rebase via the github UI, perhaps? It worked fine and helped some times in the past. After that, the bot may be able to proceed..

@Mikolaj Mikolaj force-pushed the fix/dont-drop-subcomponent-fp-targets branch from 50e38a1 to b5f0ce4 Compare February 8, 2024 16:04
@Mikolaj
Copy link
Member

Mikolaj commented Feb 8, 2024

Thanks, I rebased via the UI button.

@mergify mergify bot merged commit 0e66a4b into haskell:master Feb 8, 2024
@Mikolaj
Copy link
Member

Mikolaj commented Feb 8, 2024

@ulysses4ever, you are a wizard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of sub-component targets breaks HLS/hie-bios: we need regression test
5 participants