-
Notifications
You must be signed in to change notification settings - Fork 712
Revert "Drop sub-component targets (#8966)" #9690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Drop sub-component targets (#8966)" #9690
Conversation
This does not need to be merged as is but serves as somewhat of a reminder :) |
It's clear the ecosystem is put togheter with sticky tape If this is the only option, I reckon it's a fair call to revert. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, this reverts #8966.
I agree it's unfortunate we have to revert this. Let's at least try to improve the API, docs, tests.
A random CI infra failure: "Mikolaj token is invalid, make sure Mikolaj can still log in on the Mergify dashboard." I will keep insisting. |
@mergify refresh |
✅ Pull request refreshed |
@mergify unqueue |
☑️ The pull request is not queued |
@mergify queue |
🛑 The pull request has been removed from the queue
|
@mergify rebase |
❌ Base branch update has failed
|
I'm able to rebase just fine in #9698, so may this be something wrong with the PR? I can see "Maintainers are allowed to edit this pull request" and I don't know what else can be broken. @ulysses4ever, any ideas? |
@mergify rebase |
❌ Base branch update has failed
|
not really. Let's rebase via the github UI, perhaps? It worked fine and helped some times in the past. After that, the bot may be able to proceed.. |
This reverts commit 3f4c81f.
50e38a1
to
b5f0ce4
Compare
Thanks, I rebased via the UI button. |
@ulysses4ever, you are a wizard! |
This reverts commit 3f4c81f.
Please read Github PR Conventions and then fill in one of these two templates.
Template Β: This PR does not modify
cabal
behaviour (documentation, tests, refactoring, etc.)Include the following checklist in your PR:
Closes #9688