Skip to content

Activate extension for cabal files only if the used hls version supports it #418

Closed
@jneira

Description

@jneira
Member

Activity

jneira

jneira commented on Aug 3, 2021

@jneira
MemberAuthor

Hmm you are rigth, thanks for noting it. Could we do some change in the hls part (or the extension) to avoid those errors? To investigate.
Will do a release without this change in the meanwhile.

I think we can check in the vscode plugin for the version of the hls and hls-wrapper version to launch and conditionally enable loading of cabal files.

@fendor that is a good solution but it would apply only to some version of the vscode extension and not for other editors (so they will have those errors for older hls versions if they enable them like here)
So not sure if it worths look for a solution in hls, where those errors will start to be emitted.

added
type: enhancementAn enhancement to an already existing feature
type: setupIssues related with the extension setup, including binaries downloads
on Aug 3, 2021
jneira

jneira commented on Aug 25, 2021

@jneira
MemberAuthor

I've reverted the tracking of .cabal files temporary in #444 (91e9738)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: enhancementAn enhancement to an already existing featuretype: setupIssues related with the extension setup, including binaries downloads

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jneira

        Issue actions

          Activate extension for cabal files only if the used hls version supports it · Issue #418 · haskell/vscode-haskell