Allows to use item_wrapper_class with procs#1131
Closed
A5308Y wants to merge 2 commits intoheartcombo:masterfrom
Closed
Allows to use item_wrapper_class with procs#1131A5308Y wants to merge 2 commits intoheartcombo:masterfrom
A5308Y wants to merge 2 commits intoheartcombo:masterfrom
Conversation
I would like to have this functionality to select a specific check_box with JS. I would've expected item_wrapper class to behave like label_method and value_method and was surprised it didn't. As each checkbox depends on an item, I expected to be able to derive a class from the item of a check_box as well, instead of assigning the same class to all check_boxes.
Author
|
The build is failing because Rubinius can't install certain gems, if I understand the travis output correctly. It seems to be a general issue with the travis setup as the build status of this PR: #1109 looks very similar. |
Collaborator
|
Thank you for the pull request. I'm not sure about this one. I don't think classes need to accept procs. In fact classes are not dynamic in any Rails or Simple Form helpers, so I'd not add support for this only in If you need a complex behaviour like this I believe it is better to write your own input. Thank you again. |
Author
|
Ok. I can understand that. Thanks for looking at it and thanks for your suggestion of writing my own input. I'll look into that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to have this functionality to select a specific check_box with JS.
I would've expected item_wrapper class to behave like label_method and value_method and was surprised it didn't. As each checkbox depends on an item, I expected to be able to derive a class from the item of a check_box as well, instead of assigning the same class to all check_boxes.