Pass base object to human_attribute_name for labels#1812
Merged
nashby merged 1 commit intoheartcombo:mainfrom Jun 25, 2024
Merged
Pass base object to human_attribute_name for labels#1812nashby merged 1 commit intoheartcombo:mainfrom
human_attribute_name for labels#1812nashby merged 1 commit intoheartcombo:mainfrom
Conversation
Collaborator
|
@motine thanks, that's useful indeed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When discovering translations, Rails passes the
baseobject tohuman_attribute_name. This is helpful becausehuman_attribute_nameis a class method and does not have access to instance methods. If someone wants to customize the behavior of said method based on properties of the instance, this is not possible without this argument. This merge request makes a tiny change to pass this base object.