Remove aria-required for required fields in HTML5#1823
Merged
nashby merged 2 commits intoheartcombo:mainfrom Jun 21, 2024
aduth:rm-aria-required
Merged
Remove aria-required for required fields in HTML5#1823nashby merged 2 commits intoheartcombo:mainfrom aduth:rm-aria-required
nashby merged 2 commits intoheartcombo:mainfrom
aduth:rm-aria-required
Conversation
Collaborator
|
@aduth thank you! |
tagliala
added a commit
to DavyJonesLocker/client_side_validations-simple_form
that referenced
this pull request
Dec 8, 2025
Adjust expectations regarding the aria-required attribute in accordance with SimpleForm 5.4.0's updated handling Ref: #heartcombo/simple_form#1823 Close #199
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1822
This pull request proposes to remove the inclusion of the
aria-requiredattribute on required fields, since the fields are already assigned therequiredattribute which would be used by assistive technology to convey the field requirement. See #1822 for additional context.