Skip to content

feat(tag-groups): on-form-field & soft-accent #6054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wingkwong wants to merge 4 commits into
base: beta-4
Choose a base branch
from
Open

feat(tag-groups): on-form-field & soft-accent #6054

wingkwong wants to merge 4 commits into from

Conversation

@wingkwong
Copy link
Member

@wingkwong wingkwong commented Dec 26, 2025 •
edited
Loading

Closes #

📝 Description

originally tasks: HHTA-133, HHTA-159

  • variant = "default" | "surface" | "on-surface" | "on-form-field"
  • remove isOnSurface | isOnFormField (they both are actually visual variants)
  • remove selectedVariant
  • instead use the "soft-accent" as selected color (pending for figma design)

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

Yes. isOnSurface is removed in this PR.

📝 Additional Information

@wingkwong
feat(tag-group): selectedVariant (#6038)
b937b9d
@wingkwong
feat(tag): on-form-field (#6036)
97ecf36 
* chore(styles): update default background for tag

* feat(tag): add onFormField

* feat(docs): add on-form-field

* chore: revise on field examples

* chore: revise on field examples

* fix(input-group): move defaultValue from Input to TextField
@vercel
Copy link

vercel bot commented Dec 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
heroui Ready Ready Preview, Comment Dec 27, 2025 5:56am
heroui-sb Ready Ready Preview, Comment Dec 27, 2025 5:56am

@changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e560eb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wingkwong wingkwong added the ♿ Scope: v3 Related to HeroUI v3 label Dec 26, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 26, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/heroui-inc/heroui/@heroui/react@6054

npm i https://pkg.pr.new/heroui-inc/heroui/@heroui/styles@6054

commit: e560eb0

@wingkwong wingkwong marked this pull request as ready for review December 27, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrgarciadev jrgarciadev Awaiting requested review from jrgarciadev jrgarciadev is a code owner

Assignees

No one assigned

Labels

♿ Scope: v3 Related to HeroUI v3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wingkwong