Skip to content

fix(validators): handle additional properties object when no other properties are defined #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Jun 20, 2025

Closes #2196

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos mrlubos marked this pull request as ready for review June 20, 2025 11:55
Copy link

changeset-bot bot commented Jun 20, 2025

🦋 Changeset detected

Latest commit: 2ffb612

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 11:55am

Copy link

pkg-pr-new bot commented Jun 20, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2213
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2213
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2213

commit: 2ffb612

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 1.08696% with 91 lines in your changes missing coverage. Please review.

Project coverage is 25.03%. Comparing base (69665af) to head (2ffb612).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/plugins/valibot/plugin.ts 0.00% 69 Missing ⚠️
packages/openapi-ts/src/plugins/zod/plugin.ts 4.34% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2213      +/-   ##
==========================================
- Coverage   25.04%   25.03%   -0.01%     
==========================================
  Files         296      296              
  Lines       27770    27784      +14     
  Branches     1266     1266              
==========================================
+ Hits         6956     6957       +1     
- Misses      20805    20818      +13     
  Partials        9        9              
Flag Coverage Δ
unittests 25.03% <1.08%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrlubos mrlubos merged commit 4128000 into main Jun 20, 2025
15 of 17 checks passed
@mrlubos mrlubos deleted the fix/validators-additional-properties-object branch June 20, 2025 11:59
@github-actions github-actions bot mentioned this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zod does not generate additionalProperties
1 participant