Skip to content

fix(parser): prefer JSON media type #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025
Merged

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Jun 22, 2025

Closes #2190

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jun 22, 2025

🦋 Changeset detected

Latest commit: e335e1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review June 22, 2025 12:00
Copy link

vercel bot commented Jun 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2025 0:01am

Copy link

pkg-pr-new bot commented Jun 22, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2221
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2221
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2221

commit: e335e1e

Copy link

codecov bot commented Jun 22, 2025

Codecov Report

Attention: Patch coverage is 19.04762% with 51 lines in your changes missing coverage. Please review.

Project coverage is 24.94%. Comparing base (5d85d29) to head (e335e1e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/openapi-ts/src/openApi/2.0.x/parser/operation.ts 14.28% 6 Missing ⚠️
...s/openapi-ts/src/openApi/3.0.x/parser/operation.ts 14.28% 6 Missing ⚠️
...s/openapi-ts/src/openApi/3.1.x/parser/operation.ts 14.28% 6 Missing ⚠️
...s/openapi-ts/src/openApi/2.0.x/parser/mediaType.ts 16.66% 5 Missing ⚠️
...s/openapi-ts/src/openApi/3.0.x/parser/mediaType.ts 16.66% 5 Missing ⚠️
...s/openapi-ts/src/openApi/3.1.x/parser/mediaType.ts 16.66% 5 Missing ⚠️
.../openapi-ts/src/openApi/3.0.x/parser/pagination.ts 25.00% 3 Missing ⚠️
...s/openapi-ts/src/openApi/3.0.x/parser/parameter.ts 25.00% 3 Missing ⚠️
...openapi-ts/src/openApi/3.0.x/parser/requestBody.ts 25.00% 3 Missing ⚠️
.../openapi-ts/src/openApi/3.1.x/parser/pagination.ts 25.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2221      +/-   ##
==========================================
- Coverage   24.94%   24.94%   -0.01%     
==========================================
  Files         294      294              
  Lines       27916    27927      +11     
  Branches     1274     1274              
==========================================
  Hits         6965     6965              
- Misses      20942    20953      +11     
  Partials        9        9              
Flag Coverage Δ
unittests 24.94% <19.04%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrlubos mrlubos merged commit df03745 into main Jun 22, 2025
15 of 17 checks passed
@mrlubos mrlubos deleted the fix/axios-client-prefer-json branch June 22, 2025 12:10
@github-actions github-actions bot mentioned this pull request Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid parse 'responseType' (depends on the order content type)
1 participant