-
Notifications
You must be signed in to change notification settings - Fork 3.6k
HHH-19551 - Address deficiencies in pessimistic locking #10194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Excellent! |
hibernate-core/src/main/java/org/hibernate/query/spi/AbstractCommonQueryContract.java
Dismissed
Show dismissed
Hide dismissed
...rnate-core/src/main/java/org/hibernate/sql/ast/internal/StandardForUpdateClauseStrategy.java
Fixed
Show fixed
Hide fixed
...rnate-core/src/main/java/org/hibernate/sql/ast/internal/StandardForUpdateClauseStrategy.java
Fixed
Show fixed
Hide fixed
...rnate-core/src/main/java/org/hibernate/sql/ast/internal/StandardForUpdateClauseStrategy.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
Fixed
Show fixed
Hide fixed
...rnate-core/src/main/java/org/hibernate/sql/ast/internal/StandardForUpdateClauseStrategy.java
Fixed
Show fixed
Hide fixed
...rnate-core/src/main/java/org/hibernate/sql/ast/internal/StandardForUpdateClauseStrategy.java
Fixed
Show fixed
Hide fixed
...rnate-core/src/main/java/org/hibernate/sql/ast/internal/StandardForUpdateClauseStrategy.java
Fixed
Show fixed
Hide fixed
...rnate-core/src/main/java/org/hibernate/sql/ast/internal/StandardForUpdateClauseStrategy.java
Fixed
Show fixed
Hide fixed
Unless I did something silly, this should be just Oracle failures now. Need to investigate those more. |
hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java
Dismissed
Show dismissed
Hide dismissed
hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java
Dismissed
Show dismissed
Hide dismissed
...rnate-core/src/main/java/org/hibernate/dialect/lock/internal/SqlAstBasedLockingStrategy.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/test/java/org/hibernate/orm/test/locking/options/ScopeTests.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/test/java/org/hibernate/orm/test/locking/options/ScopeTests.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/test/java/org/hibernate/orm/test/locking/options/ScopeTests.java
Fixed
Show fixed
Hide fixed
hibernate-testing/src/main/java/org/hibernate/testing/orm/transaction/TransactionUtil.java
Fixed
Show fixed
Hide fixed
eaede26
to
321fd2e
Compare
hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/CacheDialect.java
Fixed
Show fixed
Hide fixed
...nate-community-dialects/src/main/java/org/hibernate/community/dialect/HSQLLegacyDialect.java
Fixed
Show fixed
Hide fixed
...nate-community-dialects/src/main/java/org/hibernate/community/dialect/RDMSOS2200Dialect.java
Fixed
Show fixed
Hide fixed
hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java
Fixed
Show fixed
Hide fixed
776d5f6
to
e0e279e
Compare
hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLDialect.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLDialect.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLDialect.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/main/java/org/hibernate/dialect/SQLServerDialect.java
Fixed
Show fixed
Hide fixed
535fa89
to
00f0c68
Compare
@@ -69,6 +71,10 @@ | |||
registerKeywords( info ); | |||
} | |||
|
|||
protected LockingSupport buildLockingSupport() { |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
MySQLLegacyDialect.buildLockingSupport
About to head out for ~2 weeks of PTO... About test failures:
Some things I'd still like accomplish here...
WRT (2), currently I have: public interface LockingSupport {
Metadata getMetadata();
...
interface Metadata {
LockTimeoutType getLockTimeoutType(Timeout timeout);
RowLockStrategy getReadRowLockStrategy();
RowLockStrategy getWriteRowLockStrategy();
...
}
}
public class Dialect {
...
LockingSupport getLockingSupport();
} Thinking instead of something like: public interface LockingSupport {
Metadata getMetadata();
...
interface Metadata {
LockTimeoutType getLockTimeoutType(Timeout timeout);
RowLockStrategy getRowLockStrategy();
...
}
}
public class Dialect {
...
LockingSupport getWriteLockingSupport();
LockingSupport getReadLockingSupport();
} |
HHH-19551 - Address deficiencies in pessimistic locking
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19551