Skip to content

ospf: Add RFC 9339 support #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nrybowski
Copy link
Member

@nrybowski nrybowski commented Jun 30, 2025

This PR adds the support for Reverse Metric and Reverse TE Metric advertisement through the LLS data block of Hello packets, as defined by RFC 9339.

It depends on RFC 5613 whose support has been added with #77.

TODO

  • Add Reverse (TE) Metric LLS TLVs encoding / decoding
    • Add encoding / decoding tests for OSPFv2
    • Add encoding / decoding tests for OSPFv3
  • Enable reverse metric configuration
    • Add YANG model. (There is no YANG model specific to OSPF for now, I will adapt the one for IS-IS.)
    • Extend northbound interface
      • Directly send Hello packet upon Reverse (TE) Metric enabling / disabling
    • Extend OSPF configuration to store Reverse (TE) Metric configuration
  • Implement Reverse Metric logic
    • Trigger Router LSA origination upon Reverse Metric reception

nrybowski added 3 commits July 1, 2025 11:12
This patch adds Reverse Metric and Reverse TE Metric TLVs to LLS data
blocks.

This patch hence depends on RFC 5613, added with
holo-routing#77.

Signed-off-by: Nicolas Rybowski <[email protected]>
@rwestphal
Copy link
Member

Add YANG model. (There is no YANG model specific to OSPF for now, I will adapt the one for IS-IS.)

Indeed. I see there's [email protected] but no equivalent module for OSPF.

There's draft-ietf-lsr-ospf-yang-augmentation-v1, which adds several augmenting modules to ietf-ospf. We can add our own holo-ospf-reverse-metric and potentially ask the IETF folks to integrate it into that draft. That would probably be welcome on their part, especially since it would come with a working implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants