Skip to content

Enable circleci#245

Merged
maxandersen merged 1 commit intohome-assistant-ecosystem:devfrom
maxandersen:circleci
May 14, 2019
Merged

Enable circleci#245
maxandersen merged 1 commit intohome-assistant-ecosystem:devfrom
maxandersen:circleci

Conversation

@maxandersen
Copy link
Copy Markdown
Contributor

Why:

  • homeassistant moved to circleci - time to do same for cli

This change addreses the need by:

  • adding .circleci from homeassistant with cli specific
    changes.

@maxandersen maxandersen force-pushed the circleci branch 9 times, most recently from b0332a9 to 26f54c5 Compare May 14, 2019 19:47
Why:

 * homeassistant moved to circleci - time to do same for cli

This change addreses the need by:

 * adding .circleci from homeassistant with cli specific
   changes.
 * adding mypyrc to mimic homeassistant mypy runs; for now enable
   for all code incl. tests as that’s what we've been doing so far.
   Might want to change that later.
 * change fake port used to avid value range error on circleci.
 * add codecov explicitly to requirements.
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@b8a95d8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #245   +/-   ##
======================================
  Coverage       ?   74.91%           
======================================
  Files          ?       22           
  Lines          ?     1539           
  Branches       ?        0           
======================================
  Hits           ?     1153           
  Misses         ?      386           
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a95d8...6eb5539. Read the comment docs.

@maxandersen maxandersen merged commit 14d2f48 into home-assistant-ecosystem:dev May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants