Skip to content

New Rule: button-type-require #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025
Merged

New Rule: button-type-require #1615

merged 3 commits into from
Jun 2, 2025

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 2, 2025

Fixes: #157

@coliff coliff requested a review from thedaviddias as a code owner June 2, 2025 15:39
@coliff coliff linked an issue Jun 2, 2025 that may be closed by this pull request
@coliff coliff marked this pull request as draft June 2, 2025 15:39
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (95e6a13) to head (8493c9a).
Report is 41 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #1615      +/-   ##
===========================================
+ Coverage   96.99%   100.00%   +3.00%     
===========================================
  Files           2         1       -1     
  Lines        1628         1    -1627     
  Branches      335         0     -335     
===========================================
- Hits         1579         1    -1578     
+ Misses         49         0      -49     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5f8b9...8493c9a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gemini-code-assist[bot]

This comment was marked as resolved.

@coliff coliff marked this pull request as ready for review June 2, 2025 15:48
@coliff coliff merged commit 1312a4b into main Jun 2, 2025
20 checks passed
@coliff coliff deleted the 157-button-type branch June 2, 2025 15:50
@coliff coliff changed the title New Rule: button type require New Rule: button-type-require Jun 3, 2025
@coliff coliff mentioned this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

button type
1 participant