Skip to content

hyper-util missing max_pending_accept_reset_streams #3461

New issue
New issue
Closed
Listed in 2 issues
hyperium/hyper-util
#90
Closed
hyper-util missing max_pending_accept_reset_streams#3461
Listed in 2 issues
hyperium/hyper-util
#90
Labels
C-featureCategory: feature. This is adding a new feature.E-easyEffort: easy. A task that would be a great starting point for a new contributor.K-hyper-utilCrate: hyper-util
@allan2

Description

@allan2
allan2
opened on Dec 7, 2023
Contributor

hyper 0.14.27 has it [1]. It was merged here.

hyper-util 0.1.1 is missing it [2].

The other 10 http2 methods are present. This is the only one missing.

PR incoming

Activity

allan2
added
C-bugCategory: bug. Something is wrong. This is bad!
on Dec 7, 2023
allan2
mentioned this on Dec 7, 2023
seanmonstar
added
E-easyEffort: easy. A task that would be a great starting point for a new contributor.
C-featureCategory: feature. This is adding a new feature.
K-hyper-utilCrate: hyper-util
and removed
C-bugCategory: bug. Something is wrong. This is bad!
on Dec 11, 2023
allan2
closed this as completedin bf5a793on Dec 12, 2023
allan2
mentioned this on Dec 12, 2023
seanmonstar
reopened this on Dec 12, 2023
dsgallups

dsgallups commented on Dec 28, 2023

@dsgallups
dsgallups
on Dec 28, 2023
Contributor

It appears that the referenced PR's changes didn't make the cut into 1.0.0. Is there any reason why the pattern of calling the inner value on the builder's internal builder should not also occur for max_pending_accept_reset_streams? If it should, then this parameter should be readded to hyper/src/proto/h2/server.rs.

I'm no git wizard, but I could copy/paste those changes into a new PR for hyper 1.x

dsgallups
mentioned this on Dec 28, 2023
seanmonstar
added a commit that references this issue on Dec 29, 2023

feat(http2): add `max_pending_accept_reset_streams(num)` back to HTTP…

a9fa893
dsgallups
mentioned this on Dec 29, 2023
ikrivosheev
mentioned this on Jan 16, 2024

9 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-featureCategory: feature. This is adding a new feature.E-easyEffort: easy. A task that would be a great starting point for a new contributor.K-hyper-utilCrate: hyper-util

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @seanmonstar@allan2@dsgallups

      Issue actions
        hyper-util missing `max_pending_accept_reset_streams` · Issue #3461 · hyperium/hyper