Skip to content

Backport initial_max_send_streams support to 0.14.x #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 0.14.x
Choose a base branch
from

Conversation

Ralith
Copy link

@Ralith Ralith commented Jun 3, 2025

This backports the relevant changes from hyperium/h2#731. Happy to drop the changed default if minimizing disruption to existing users is preferred, but I suspect the current behavior is detrimental to most users (see e.g. facebook/buck2#316) and the tweaked default will make things better.

@seanmonstar
Copy link
Member

Just as a general note, v1 came out 1.5 years ago, and I'm reducing the amount of maintenance done to 0.14. I know there's less initial work if someone else backports, but if a new patch disrupts someone unexpectedly, I need to put more maintenance in a dying branch.

That's not to say we can't do this...

@Ralith
Copy link
Author

Ralith commented Jun 3, 2025

Yeah. Luckily it's a clean backport, so risk should be pretty low. Just need a decision on the changed default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants