Skip to content

enhanced commit pipelines (fabric and orion) #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 10, 2024
Merged

Conversation

adecaro
Copy link
Contributor

@adecaro adecaro commented Mar 27, 2024

This PR introduces the following to the commit pipelines of fabric and orion:

  • introduce ErrDiscardTX to explicitly signal that a transaction needs to be discarded even though it is valid for the backend.
  • introduce validation message to be stored in the vault.

@adecaro adecaro self-assigned this Mar 27, 2024
@@ -195,12 +199,15 @@ func (c *Committer) IsFinal(ctx context.Context, txID string) error {
if logger.IsEnabledFor(zapcore.DebugLevel) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cases for Busy and HasDependencies implement the same logic. We could group them. Also we could remove one nesting by doing

for _, id := range deps {
...
}
if len(deps) > 0 {
return nil
}

But this is more of personal taste

@adecaro adecaro changed the title improved commit pipelines (fabric and orion) enhancements commit pipelines (fabric and orion) Apr 9, 2024
@adecaro adecaro changed the title enhancements commit pipelines (fabric and orion) enhanced commit pipelines (fabric and orion) Apr 9, 2024
Copy link
Contributor

@alexandrosfilios alexandrosfilios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adecaro and others added 20 commits April 10, 2024 10:13
- introduce validation message

Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro adecaro force-pushed the f-improved-committer branch from e396f9a to da48426 Compare April 10, 2024 08:13
@adecaro adecaro merged commit 3d6b61b into main Apr 10, 2024
@adecaro adecaro deleted the f-improved-committer branch April 10, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants