Performance #597
Merged
Performance #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrosfilios
force-pushed
the
performance-2
branch
from
9c6f4ad to
ccce6e6
Compare
alexandrosfilios
force-pushed
the
performance
branch
from
4fb4586 to
d2de4f2
Compare
alexandrosfilios
force-pushed
the
performance-2
branch
from
ccce6e6 to
d193a59
Compare
Signed-off-by: Alexandros Filios <[email protected]>
alexandrosfilios
force-pushed
the
performance-2
branch
from
d193a59 to
0417f9c
Compare
alexandrosfilios
force-pushed
the
performance-2
branch
2 times, most recently
from
37abd37 to
9c6e003
Compare
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
alexandrosfilios
force-pushed
the
performance-2
branch
from
9c6e003 to
120dbcd
Compare
adecaro
approved these changes
Jun 18, 2024
| } | ||
| viewContext, err := NewContextForInitiator("", ctx, cm.sp, cm.commLayer, cm.endpointService, id, view, cm.viewTracer) | ||
| func (cm *manager) InitiateViewWithIdentity(view view.View, id view.Identity, ctx context.Context) (interface{}, error) { | ||
| newCtx, span := cm.viewTracer.Start(ctx, "initiate_view_with_identity") |
There was a problem hiding this comment.
could we start this trace by adding to the name also the ID of the viewContext?
There was a problem hiding this comment.
We can add it as an attribute. Let's take this up in a separate PR
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.