Support for traces in sessions #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrosfilios
force-pushed
the
f-traces-session
branch
from
c257f4f to
b67df0f
Compare
alexandrosfilios
force-pushed
the
f-traces-session
branch
from
a8ac53d to
9aa5b61
Compare
adecaro
reviewed
Jul 4, 2024
| @@ -23,6 +24,7 @@ type Message struct { | |||
| FromPKID []byte // PK identifier of the caller | |||
| Status int32 // Message Status (OK, ERROR) | |||
| Payload []byte // Payload | |||
| Ctx context.Context | |||
There was a problem hiding this comment.
is this guaranteed to be serializable?
There was a problem hiding this comment.
it isn't, but it doesn't have to be
| @@ -53,9 +55,15 @@ type Session interface { | |||
| // Send sends the payload to the endpoint | |||
| Send(payload []byte) error | |||
|
|
|||
| // SendWithContext sends the payload to the endpoint with the passed context | |||
There was a problem hiding this comment.
does this mean that the context is part of the message or the context is used to control the send operation itself?
There was a problem hiding this comment.
no it's part of the message. it carries some information. in this case the span context
There was a problem hiding this comment.
I would clarify in the comment then
There was a problem hiding this comment.
No but the context doesn't have to do only with the span. The span uses the context but the context has more functions in general, e.g. canceling the context, or adding baggage values
alexandrosfilios
force-pushed
the
f-traces-session
branch
from
be708a5 to
880a2f5
Compare
Signed-off-by: Alexandros Filios <[email protected]>
alexandrosfilios
force-pushed
the
f-traces-session
branch
from
880a2f5 to
ed0ee4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.