Skip to content

check if grpc server is nil before accessing it #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

arner
Copy link
Contributor

@arner arner commented Jul 2, 2024

caused panic if grpc.enabled: false.

@arner arner requested a review from alexandrosfilios July 2, 2024 10:21
@adecaro adecaro self-requested a review July 2, 2024 13:54
Copy link
Contributor

@adecaro adecaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adecaro adecaro merged commit 63e0fa8 into main Jul 2, 2024
18 checks passed
@adecaro adecaro deleted the bug-nil-grpc branch December 12, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants