Added node name as service name #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrosfilios
force-pushed
the
node-name-tracing
branch
from
4b006e8 to
c2a7b22
Compare
Signed-off-by: Alexandros Filios <[email protected]>
alexandrosfilios
force-pushed
the
node-name-tracing
branch
from
c2a7b22 to
7b58355
Compare
adecaro
reviewed
Aug 13, 2024
| return newTracerProviderFromConfig(c, ServiceName) | ||
| } | ||
|
|
||
| func newTracerProviderFromConfig(c Config, serviceName string) (trace.TracerProvider, error) { |
There was a problem hiding this comment.
is it okay if service name is empty?
There was a problem hiding this comment.
I don't think it can, but I haven't tried it. The code doesn't allow this though.
adecaro
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.