Skip to content

upgrade go and dependencies #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 17, 2024
Merged

upgrade go and dependencies #651

merged 5 commits into from
Aug 17, 2024

Conversation

arner
Copy link
Contributor

@arner arner commented Aug 14, 2024

No description provided.

@arner arner requested a review from adecaro August 14, 2024 08:52
Signed-off-by: Arne Rutjes <[email protected]>
Copy link
Contributor

@adecaro adecaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo some comments.

@@ -16,7 +16,7 @@ topologies:
Aliases:
- bob
logging:
spec: grpc=error:info
spec: grpc=error,view-sdk.services.comm,view-sdk=debug:info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this additional spec?

@@ -17,6 +17,7 @@ func Topology(commType fsc.P2PCommunicationType, replicationOpts *integration.Re
topology := fsc.NewTopology()
topology.WebEnabled = true
topology.P2PCommunicationType = commType
topology.Logging.Spec = "view-sdk.services.comm,view-sdk=debug:info"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this?

arner and others added 3 commits August 15, 2024 16:38
Signed-off-by: Arne Rutjes <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro adecaro merged commit 388a033 into main Aug 17, 2024
18 checks passed
@adecaro adecaro deleted the upgrade-deps branch August 17, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants