-
Notifications
You must be signed in to change notification settings - Fork 58
upgrade go and dependencies #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Arne Rutjes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo some comments.
@@ -16,7 +16,7 @@ topologies: | |||
Aliases: | |||
- bob | |||
logging: | |||
spec: grpc=error:info | |||
spec: grpc=error,view-sdk.services.comm,view-sdk=debug:info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this additional spec?
integration/fsc/pingpong/topology.go
Outdated
@@ -17,6 +17,7 @@ func Topology(commType fsc.P2PCommunicationType, replicationOpts *integration.Re | |||
topology := fsc.NewTopology() | |||
topology.WebEnabled = true | |||
topology.P2PCommunicationType = commType | |||
topology.Logging.Spec = "view-sdk.services.comm,view-sdk=debug:info" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this?
Signed-off-by: Arne Rutjes <[email protected]>
…le with the BCCSP config Signed-off-by: Arne Rutjes <[email protected]>
Signed-off-by: Arne Rutjes <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
No description provided.