Removed pq dependencies #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arner
reviewed
Dec 9, 2024
go.mod
Outdated
| github.com/jellydator/ttlcache/v2 v2.11.1 | ||
| github.com/lib/pq v1.10.9 | ||
| github.com/lib/pq v0.0.0-20180201184707-88edab080323 |
There was a problem hiding this comment.
Looks like it's still imported in some places:
./integration/nwo/fsc/node/node_template.go
./integration/fabric/iouhsm/cmd/lender/main.go
./integration/fabric/iouhsm/cmd/borrower/main.go
./platform/view/services/db/driver/sql/sqlite/sql_test.go
./platform/view/services/db/driver/sql/common/test_utils.go
./platform/view/services/db/driver/sql/postgres/persistence.go
./platform/view/services/db/driver/sql/postgres/test_utils.go
./platform/view/services/db/driver/sql/postgres/sql_test.go
alexandrosfilios
force-pushed
the
f-update-pg
branch
from
f32272c to
128ade7
Compare
|
yes, @alexandrosfilios , can we get rid completely of github.com/lib/pq v0.0.0-20180201184707-88edab080323 ? |
Signed-off-by: Alexandros Filios <[email protected]>
alexandrosfilios
force-pushed
the
f-update-pg
branch
from
afc8e4b to
fe4f565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.