audit improvements #454
Merged
audit improvements #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkatdlog driver: better logs Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
KElkhiyaoui
reviewed
Feb 14, 2023
token/core/zkatdlog/nogh/auditor.go
Outdated
| @@ -16,13 +16,15 @@ import ( | |||
|
|
|||
| // AuditorCheck verifies if the passed tokenRequest matches the tokenRequestMetadata | |||
| func (s *Service) AuditorCheck(tokenRequest *driver.TokenRequest, tokenRequestMetadata *driver.TokenRequestMetadata, txID string) error { | |||
| logger.Debugf("check token request validity...") | |||
| logger.Debugf("[%s] check token request validity, number of transfer action [%d]...", txID, len(tokenRequestMetadata.Transfers)) | |||
There was a problem hiding this comment.
number of transfer actions
Signed-off-by: Angelo De Caro <[email protected]>
KElkhiyaoui
reviewed
Feb 14, 2023
token/core/zkatdlog/nogh/auditor.go
Outdated
| inputs, err := s.TokenCommitmentLoader.GetTokenOutputs(transfer.TokenIDs) | ||
| if err != nil { | ||
| return errors.Wrapf(err, "failed getting token outputs to perform auditor check") | ||
| } | ||
| logger.Debugf("[%s] transfer action [%d] contains [%d] inputs, loaded corresponding outputs [%d]", txID, i, len(transfer.TokenIDs), len(inputs)) |
There was a problem hiding this comment.
contains [%d] token IDs, loaded corresponding inputs [%d]
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
KElkhiyaoui
reviewed
Feb 14, 2023
token/core/zkatdlog/nogh/sender.go
Outdated
| auditInfo, err := htlc.GetOwnerAuditInfo(t.Owner, s) | ||
| if err != nil { | ||
| return nil, nil, errors.Wrapf(err, "failed getting audit info for sender identity [%s]", view.Identity(t.Owner).String()) | ||
| } | ||
| if len(auditInfo) == 0 { | ||
| logger.Errorf("empty audit info for token [%s] ith owner [%s]", ids[i].String(), view.Identity(t.Owner)) |
There was a problem hiding this comment.
for the owner [%s] of the i^th token [%s]
KElkhiyaoui
reviewed
Feb 14, 2023
token/services/ttx/auditor.go
Outdated
| if err := view2.GetRegistry(context).RegisterResponder(r.AuditView, &AuditingViewInitiator{}); err != nil { | ||
| return nil, errors.Wrapf(err, "failed to register auditor view") | ||
| } | ||
|
|
||
| // enable processing all token transactions for the given network and namespace |
There was a problem hiding this comment.
enable processing of all token transactions for the given...
Signed-off-by: Angelo De Caro <[email protected]>
KElkhiyaoui
reviewed
Feb 14, 2023
token/services/ttx/auditor.go
Outdated
| } | ||
| net := network.GetInstance(context, tms.Network(), tms.Channel()) | ||
| if tms == nil { | ||
| return nil, errors.Errorf("cannot find netowkr for [%s]", tms.ID()) |
KElkhiyaoui
approved these changes
Feb 14, 2023
Signed-off-by: Angelo De Caro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ttx.audit: store transiant as soon as possible
zkatdlog driver: better logs
Linked to hyperledger-labs/fabric-smart-client#453
Signed-off-by: Angelo De Caro [email protected]