clean up dependencies of sdk.go #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -140,6 +141,73 @@ func (p *ManagementServiceProvider) managementService(aNew bool, opts ...Service | |||
| return ms, nil | |||
| } | |||
|
|
|||
| func (p *ManagementServiceProvider) normalize(opt *ServiceOptions) (*ServiceOptions, error) { | |||
| // lookup configurations | |||
| configs, err := p.tmsProvider.Configs() | |||
There was a problem hiding this comment.
Maybe it's better to create another struct that implements the normaliser interface and pass the slice of normalisers.
token/sdk/sdk.go
Outdated
| @@ -205,9 +179,18 @@ func (p *SDK) Start(ctx context.Context) error { | |||
| logger.Infof("start token management service [%s]...", tmsID) | |||
|
|
|||
| // connect network | |||
| if err := p.postInitializer.ConnectNetwork(tmsID.Network, tmsID.Channel, tmsID.Namespace); err != nil { | |||
| net := network.GetInstance(p.registry, tmsID.Network, tmsID.Channel) | |||
There was a problem hiding this comment.
Since we are in the sdk and we have access to the network provider, the tms provider etc, maybe we could use those instead of calling the registry
| New(tmsID token3.TMSID) (F, error) | ||
| } | ||
|
|
||
| type AcceptTxInDBFilterProvider struct { |
There was a problem hiding this comment.
Maybe a comment to describe more or less what this filter is used for
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.