improvements #772
Merged
improvements #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
adecaro
force-pushed
the
f-err-handling
branch
from
df21909 to
78e85ed
Compare
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
| // LocalIdentity contains information about an identity | ||
| type LocalIdentity struct { | ||
| Name string `yaml:"name,omitempty"` | ||
| EnrollmentID string |
There was a problem hiding this comment.
Do we need annotations for the rest of the properties?
There was a problem hiding this comment.
I think we don't need here at all
| } | ||
|
|
||
| func (l *LocalMembership) IDs() ([]string, error) { | ||
| var ids []string |
There was a problem hiding this comment.
Do we need an rlock here?
| @@ -98,7 +92,6 @@ func (d *Driver) New(network, _ string) (driver.Network, error) { | |||
| d.configService, | |||
| d.filterProvider, | |||
| dbManager, | |||
| d.defaultPublicParamsFetcher, | |||
There was a problem hiding this comment.
It makes sense not to inject the fetcher. But i would keep it in the constructor as it helps extending the network and reusing functionality.
There was a problem hiding this comment.
it is that we just don't need it here
- add locking where needed in the local membership struct Signed-off-by: Angelo De Caro <[email protected]>
adecaro
force-pushed
the
f-err-handling
branch
from
75fc57a to
0e50aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: