Update Gradle plugins and replace unmaintained license plugin by fab-10 · Pull Request #6275 · besu-eth/besu

fab-10 · 2023-12-11T16:09:53Z

PR description

Update all the Gradle plugins to their latest version, and replace the unmaintained hierynomus.license plugin with the actively maintained Gradle License Report.
There are also few GHA Gradle cache optimizations.

Fixed Issue(s)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

github-actions · 2023-12-11T16:10:11Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

macfarla · 2023-12-15T02:22:37Z

.github/workflows/codeql.yml

+      uses: actions/setup-java@v4
      with:
-        distribution: adopt
+        distribution: 'temurin'


is this change related?

it is part of the GHA opt, adopt is deprecated and replaced by "temurin", so updated to the latter everywhere

# Conflicts: # CHANGELOG.md

…th#6275) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us>

…th#6275) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

…th#6275) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us>

* Increase scope of reference tests (#6287) Add new forks to transaction tests, add bad rlp to rlp ref tests. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: jflo <justin+github@florentine.us> * Add trace to web socket JSON/RPC responses (#6285) * Add trace to web socket JSON/RPC responses Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Don't throw runtime exception if we can't parse JSON for trace Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * [MINOR] Include Enode URL in error message if parsing exception (#6288) * include the actual Enode URL in the error message if IP can't be resolved --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * Execute the terminatedImmediately method only once (#6284) Signed-off-by: David Lutzardo <jdlutzardo@izertis.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * move forest class to a specific package (#6293) cleaning up the worldstate section, moving and renaming everything that is forest into a specific package in order to clarify the difference between Bonsai and Forest in the code. --------- Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: matkt <karim.t2am@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * removed vintage junit dependency (#6296) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * updated cli and chainimport/export tests to junit 5 (#6281) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * [MINOR] CLI Subcommands migrate to junit 5 (#6282) * updated cli and chainimport/export tests to junit 5 Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * subcommands and besucommand test to junit5 Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * removed duplicate line Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * removed vintage junit dep Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us> * [MINOR] add genesis file name to config overview (#6297) * add genesis file name to config overview Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * create trie package for bonsai and forest (#6300) Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: matkt <karim.t2am@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * [MINOR] More cli tests to junit 5 (#6283) * more CLI and services tests to junit5 --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us> * Update Gradle plugins and replace unmaintained license plugin (#6275) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us> * Quick fix to avoid a tight loop when processing added blocks in txpool (#6309) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us> * uprev to version 23.10.3-RC4 Signed-off-by: jflo <justin+github@florentine.us> * mark deleted slot during clear storage step Signed-off-by: Karim Taam <karim.t2am@gmail.com> --------- Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: jflo <justin+github@florentine.us> Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: David Lutzardo <jdlutzardo@izertis.com> Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: matkt <karim.t2am@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: Matt Whitehead <matthew1001@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: David Lutzardo <jdlutzardo@izertis.com> Co-authored-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>

fab-10 added 7 commits December 11, 2023 15:48

Update Gradle spotless plugin

fa5f38d

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Update Gradle plugin com.github.ben-manes.versions

41838d8

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Update Gradle plugin com.jfrog.artifactory

25fc970

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Update Gradle plugin io.spring.dependency-management

ce281d4

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Update Gradle plugin me.champeau.jmh

1646fae

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Update Gradle plugin net.ltgt.errorprone

58cc0db

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Update Gradle plugin org.sonarqube

c6ced92

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Clean verification metadata

2494ab0

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

fab-10 force-pushed the update-gradle-plugins branch from a19ae8d to 2494ab0 Compare December 11, 2023 16:23

fab-10 added 4 commits December 11, 2023 18:36

remove space

f9ff1a3

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Merge branch 'main' into update-gradle-plugins

f4d3760

Merge branch 'main' into update-gradle-plugins

3e4dc7c

More verification metadata

69a193b

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

fab-10 force-pushed the update-gradle-plugins branch 3 times, most recently from e6fcf02 to cae6d80 Compare December 13, 2023 15:38

Tune GHA gradle cache + verification metadata

27d400d

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

fab-10 force-pushed the update-gradle-plugins branch from cae6d80 to 27d400d Compare December 13, 2023 16:02

fab-10 changed the title ~~Update Gradle plugins~~ Update Gradle plugins + GHA setup Java action optimations Dec 13, 2023

fab-10 changed the title ~~Update Gradle plugins + GHA setup Java action optimations~~ Update Gradle plugins + GHA setup Java action optimizations Dec 13, 2023

Replace unmantained Gradle license plugin

fdc450c

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

fab-10 force-pushed the update-gradle-plugins branch from 3b1ce21 to fdc450c Compare December 14, 2023 12:00

fab-10 changed the title ~~Update Gradle plugins + GHA setup Java action optimizations~~ Update Gradle plugins and replace unmaintained license plugin Dec 14, 2023

fab-10 added 2 commits December 14, 2023 13:50

Merge branch 'main' into update-gradle-plugins

8f6b202

Update CHANGELOG

38fabd4

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

fab-10 marked this pull request as ready for review December 14, 2023 12:53

macfarla approved these changes Dec 15, 2023

View reviewed changes

Merge branch 'main' into update-gradle-plugins

758b80f

# Conflicts: # CHANGELOG.md

fab-10 enabled auto-merge (squash) December 18, 2023 09:37

fab-10 merged commit 1a7244f into besu-eth:main Dec 18, 2023

fab-10 deleted the update-gradle-plugins branch December 18, 2023 10:10

jflo pushed a commit to jflo/besu that referenced this pull request Dec 18, 2023

Update Gradle plugins and replace unmaintained license plugin (besu-e…

966c394

…th#6275) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us>

jflo pushed a commit to jflo/besu that referenced this pull request Dec 18, 2023

Update Gradle plugins and replace unmaintained license plugin (besu-e…

04247c9

…th#6275) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

jflo pushed a commit to jflo/besu that referenced this pull request Dec 18, 2023

Update Gradle plugins and replace unmaintained license plugin (besu-e…

15ac7b6

…th#6275) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Gradle plugins and replace unmaintained license plugin#6275

Update Gradle plugins and replace unmaintained license plugin#6275
fab-10 merged 17 commits intobesu-eth:mainfrom
fab-10:update-gradle-plugins

fab-10 commented Dec 11, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Dec 11, 2023

Uh oh!

macfarla Dec 15, 2023

Uh oh!

fab-10 Dec 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

fab-10 commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description

Fixed Issue(s)

Uh oh!

github-actions bot commented Dec 11, 2023

Uh oh!

macfarla Dec 15, 2023

Choose a reason for hiding this comment

Uh oh!

fab-10 Dec 18, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fab-10 commented Dec 11, 2023 •

edited

Loading